Ein Anderssono
85eaa3ea37
Critical: - Replace DISPATCH_TIME_FOREVER with 120s/30s timeouts in ObjC - Log failed asset IDs and error messages in cmdExport/backupTree - Show failed count in export summaries Cleanup: - Remove legacy Bridge methods (ExportAlbumPreviews, ExportAlbumOriginals, BackupAll) - Remove legacy ObjC functions and C stub equivalents - Remove photos.go delegates (package-level pass-throughs) - Remove InterpretExportResult (only used by legacy methods) - Clean up mockBridge fields (rename Fn2 -> Fn) - Fix rc race condition in main_main.go (atomic.Int32) - Remove unused variables (_ = grandTotal, _ = sig) Design: - Fix resolveAlbumID: ListAlbums first (cheap), then direct ID - Unify Cloud type: Asset.Cloud string (was bool) - Extract shared export logic into exportAssets/exportOne - Add worker pool for parallel exports (3 workers when assets >= 4) - Fix backupTree progress bar counter and directory prefix Robustness: - Add nil checks for stringWithUTF8String: in ObjC - Log directory creation errors in ensure_directory (ObjC) Quality: - Add go vet and -race flag to Makefile test target - Add ADR for performSelector cloudIdentifier decision - Add sync comments between Go/ObjC sanitizePathComponent - Add package-level doc comment - Add tests: partial failure, skipped album, album-not-found message
83 lines
2.5 KiB
C
83 lines
2.5 KiB
C
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
static char *alloc_json(const char *s) {
|
|
size_t len = strlen(s);
|
|
char *copy = (char *)malloc(len + 1);
|
|
memcpy(copy, s, len);
|
|
copy[len] = '\0';
|
|
return copy;
|
|
}
|
|
|
|
static int stub_access_rc = 0;
|
|
static const char *stub_albums_json = "{\"albums\":[]}";
|
|
static const char *stub_assets_json = "{\"assets\":[]}";
|
|
static const char *stub_tree_json = "{\"collections\":[]}";
|
|
static int stub_albums_null = 0;
|
|
static int stub_assets_null = 0;
|
|
static int stub_tree_null = 0;
|
|
static int stub_cancelled = 0;
|
|
static const char *stub_export_preview_json = NULL;
|
|
static const char *stub_export_original_json = NULL;
|
|
|
|
static char *maybe_alloc_json(const char *s) {
|
|
if (!s) return NULL;
|
|
return alloc_json(s);
|
|
}
|
|
|
|
void photos_test_set_access(int rc) { stub_access_rc = rc; }
|
|
void photos_test_set_albums(const char *json) { stub_albums_json = json; stub_albums_null = 0; }
|
|
void photos_test_set_assets(const char *json) { stub_assets_json = json; stub_assets_null = 0; }
|
|
void photos_test_set_tree(const char *json) { stub_tree_json = json; stub_tree_null = 0; }
|
|
void photos_test_set_albums_null(void) { stub_albums_null = 1; }
|
|
void photos_test_set_assets_null(void) { stub_assets_null = 1; }
|
|
void photos_test_set_tree_null(void) { stub_tree_null = 1; }
|
|
|
|
int photos_request_access(void) { return stub_access_rc; }
|
|
|
|
char *photos_list_albums_json(void) {
|
|
if (stub_albums_null) return NULL;
|
|
return alloc_json(stub_albums_json);
|
|
}
|
|
|
|
char *photos_list_assets_json(const char *album_id) {
|
|
(void)album_id;
|
|
if (stub_assets_null) return NULL;
|
|
return alloc_json(stub_assets_json);
|
|
}
|
|
|
|
char *photos_export_preview_json(const char *asset_id, const char *output_dir, int target_size, int index) {
|
|
(void)asset_id;
|
|
(void)output_dir;
|
|
(void)target_size;
|
|
(void)index;
|
|
return maybe_alloc_json(stub_export_preview_json);
|
|
}
|
|
|
|
char *photos_export_original_json(const char *asset_id, const char *output_dir, int index) {
|
|
(void)asset_id;
|
|
(void)output_dir;
|
|
(void)index;
|
|
return maybe_alloc_json(stub_export_original_json);
|
|
}
|
|
|
|
char *photos_list_tree_json(void) {
|
|
if (stub_tree_null) return NULL;
|
|
return alloc_json(stub_tree_json);
|
|
}
|
|
|
|
void photos_free_string(char *value) {
|
|
if (value) free(value);
|
|
}
|
|
|
|
void photos_request_cancel(void) {
|
|
stub_cancelled = 1;
|
|
}
|
|
|
|
void photos_test_set_export_preview_json(const char *json) {
|
|
stub_export_preview_json = json;
|
|
}
|
|
|
|
void photos_test_set_export_original_json(const char *json) {
|
|
stub_export_original_json = json;
|
|
} |