Ein Anderssono
85eaa3ea37
Critical: - Replace DISPATCH_TIME_FOREVER with 120s/30s timeouts in ObjC - Log failed asset IDs and error messages in cmdExport/backupTree - Show failed count in export summaries Cleanup: - Remove legacy Bridge methods (ExportAlbumPreviews, ExportAlbumOriginals, BackupAll) - Remove legacy ObjC functions and C stub equivalents - Remove photos.go delegates (package-level pass-throughs) - Remove InterpretExportResult (only used by legacy methods) - Clean up mockBridge fields (rename Fn2 -> Fn) - Fix rc race condition in main_main.go (atomic.Int32) - Remove unused variables (_ = grandTotal, _ = sig) Design: - Fix resolveAlbumID: ListAlbums first (cheap), then direct ID - Unify Cloud type: Asset.Cloud string (was bool) - Extract shared export logic into exportAssets/exportOne - Add worker pool for parallel exports (3 workers when assets >= 4) - Fix backupTree progress bar counter and directory prefix Robustness: - Add nil checks for stringWithUTF8String: in ObjC - Log directory creation errors in ensure_directory (ObjC) Quality: - Add go vet and -race flag to Makefile test target - Add ADR for performSelector cloudIdentifier decision - Add sync comments between Go/ObjC sanitizePathComponent - Add package-level doc comment - Add tests: partial failure, skipped album, album-not-found message
48 lines
952 B
Go
48 lines
952 B
Go
package photos
|
|
|
|
type Album struct {
|
|
ID string `json:"id"`
|
|
Title string `json:"title"`
|
|
}
|
|
|
|
type Asset struct {
|
|
ID string `json:"id"`
|
|
Filename string `json:"filename"`
|
|
Cloud string `json:"cloud"`
|
|
}
|
|
|
|
type ExportResult struct {
|
|
Filename string `json:"filename"`
|
|
Size int64 `json:"size"`
|
|
Cloud string `json:"cloud"`
|
|
Error string `json:"error,omitempty"`
|
|
}
|
|
|
|
type CollectionNode struct {
|
|
ID string `json:"id,omitempty"`
|
|
Name string `json:"name"`
|
|
Kind string `json:"kind"`
|
|
Children []CollectionNode `json:"children,omitempty"`
|
|
}
|
|
|
|
type AlbumsResponse struct {
|
|
Albums []Album `json:"albums"`
|
|
}
|
|
|
|
type AssetsResponse struct {
|
|
Assets []Asset `json:"assets"`
|
|
Total int `json:"total"`
|
|
}
|
|
|
|
type TreeResponse struct {
|
|
Collections []CollectionNode `json:"collections"`
|
|
}
|
|
|
|
type ErrorResponse struct {
|
|
Error string `json:"error"`
|
|
}
|
|
|
|
type ExportResultResponse struct {
|
|
ExportResult
|
|
}
|